-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all tether tooltip placement options and update docs #17759
Comments
+1 |
Pull request #20696 closed out issue #19796 which addresses the incorrect documentation with regard to the 'auto' option. With that said, removal of the 'auto' option is quite a step back as tooltips can now be clipped easily on smaller screens. I do believe a replacement for 'auto' is important. One option is to replace Tether, as requested here: #19673. |
The milestone has been changed to v4.1 ideas. Why? From what the OP says, this isn't a big change. And this only adds an inconsistency since (according to the docs) Popovers still support the 'auto' option. EDIT After testing, popovers don't support the 'auto' option, perhaps that should be removed from the docs too. Also, I was not aware that you could pass an array of constraints to Tether through the options object, it looks like that can be used as a workaround until these options are implemented. |
I'm cooking a PR to enable all of tether placement options in bootstrap. Considering v4 is on the verge of beta, I will make sure not break any current implementation (namely allow all 4 current placement options, in addition to the new ones). |
Now when we switched to Popper maybe you could create a PR to support Popper positioning options? |
It would be a great improvement for sure 👍 |
I'd be happy to! busy week tough, probably next weekend i can sink my teeth in it. |
Closing since dropping Tether for Popper. |
Currently bootstrap only supports 4 placement options, while tether supports 12.
Can we allow bootstrap's
_getAttachment
function to fall back to just routing the placement value straight through to tether if the map is not found? In other words, if I supply{placement: 'top right'}
tether should happily receive it and not throw an error "You must provide an attachment".On a side note, the docs need updating as the "auto" placement is no longer supported.
The text was updated successfully, but these errors were encountered: