Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.alert-dismissible as default target for Dismissible alerts #16150

Closed
ghost opened this issue Mar 25, 2015 · 1 comment
Closed

.alert-dismissible as default target for Dismissible alerts #16150

ghost opened this issue Mar 25, 2015 · 1 comment
Labels

Comments

@ghost
Copy link

ghost commented Mar 25, 2015

The Bootstrap docs indicated that "When using a .close button, it must be the first child of the .alert-dismissible ...".

But actually, the real target selector for the event is .alert.

It seems to me more logical to change the selector in the file alert.js at line number 39 to: $parent = $this.closest('.alert-dismissible')

Thus the .alert class unbinds from JavaScript and allows you to use dismissible alerts without must-have styles from the class .alert. Use only class .alert-dismissible, as described in the documentation.

@juthilo juthilo added the js label Mar 25, 2015
@hnrch02
Copy link
Collaborator

hnrch02 commented Mar 26, 2015

That'd be something for v4 since all .alert-dismissible does is adjust the positioning and color of the .close button slightly so some people just leave it out. I'll make a note though.

@hnrch02 hnrch02 closed this as completed Mar 26, 2015
@mdo mdo mentioned this issue Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants