Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmented input group buttons have wrong border radius #13150

Closed
hotzenklotz opened this issue Mar 22, 2014 · 3 comments
Closed

Segmented input group buttons have wrong border radius #13150

hotzenklotz opened this issue Mar 22, 2014 · 3 comments

Comments

@hotzenklotz
Copy link

Hi,

when switching the 'action' and 'dropdown' button in the segmented input group from the docs causes a wrong border radius for the buttons.
Interestingly enough it works fine on the left side, but comes out wrong on the right side. See screenshot for clarity:

screen shot 2014-03-22 at 21 44 02

@cvrebert
Copy link
Collaborator

Duplicate of #11489 / #11475, but those weren't fixed, and we're trying to support RTL now, so leaving this issue open.

@cvrebert cvrebert added this to the v3.2.0 milestone Mar 23, 2014
@cvrebert cvrebert modified the milestones: v3.2.1, v3.2.0 Jun 8, 2014
@mdo
Copy link
Member

mdo commented Jun 19, 2014

This CSS sucks so bad right now lol. Going to take some time to figure out how to target this properly.

@mdo
Copy link
Member

mdo commented Jun 19, 2014

This is basically impossible given the constraints of CSS selectors and the presence of a dropdown menu. For the time being, I'm afraid this is a can't fix and we'll punt to v4 to maybe re-evaluate how these components are put together.


Expanding on the can't fix:

  • We cheat with rounding the .dropdown-toggle because it has a special class.
  • We need that because of the .dropdown-menu.
  • We can't do :nth-child because IE8 doesn't support it.
  • We can't say :last-child-1 because that CSS doesn't exist.
  • We could require another class, but that sounds awful given the current block of CSS magic doing the rounding here for us.

Bottom line? Basically impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants