Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grunt-autoprefixer to grunt tasks #12452

Closed
mrmrs opened this issue Jan 31, 2014 · 9 comments
Closed

Add grunt-autoprefixer to grunt tasks #12452

mrmrs opened this issue Jan 31, 2014 · 9 comments

Comments

@mrmrs
Copy link
Contributor

mrmrs commented Jan 31, 2014

Instead of maintaining mixins for things like box-shadow and transition - we should just implement as part of our build process via this grunt task for autoprefixer. It runs off of the info from http://caniuse.com which makes it much easier to maintain proper vendor prefixes. Less mixins seems worth the price of admission alone.

@zlatanvasovic
Copy link
Contributor

I think no. Bootstrap doesn't need all the prefixes.

@hnrch02
Copy link
Collaborator

hnrch02 commented Feb 2, 2014

autoprefixer doesn't just add all the prefixes, it actually can be tuned very fine.

@zlatanvasovic
Copy link
Contributor

I know, but is it really required? It disallows removal of specific prefix, when caniuse becomes outdated.

@hnrch02
Copy link
Collaborator

hnrch02 commented Feb 2, 2014

caniuse is updated every couple of days, I don't think that we'd need to worry about that.

@zlatanvasovic
Copy link
Contributor

Ok then. We have to try. :)

@hnrch02
Copy link
Collaborator

hnrch02 commented Feb 2, 2014

It's definitely something @mdo and the rest of the team has to decide.
/cc @cvrebert @juthilo

@mdo
Copy link
Member

mdo commented Feb 4, 2014

I'm down with it. I'd love for mixins to be only for code snippets and not prefixing. We can deprecate any of those mixins and switch to the autoprefixing, but I wonder if there would be any kind of conflict in that?

Would also be super cool to see a list of what can be switched over and what can't.

@juthilo juthilo added this to the v3.2.0 milestone Feb 8, 2014
@mdo
Copy link
Member

mdo commented Mar 7, 2014

Done! #12670

@mdo mdo closed this as completed Mar 7, 2014
@hnrch02
Copy link
Collaborator

hnrch02 commented Mar 7, 2014

🎆 🎉 🎊 :bowtie:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants