Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible Naming Conventions Inconsistent #10481

Closed
willpracht opened this issue Sep 5, 2013 · 2 comments · Fixed by #10641
Closed

Collapsible Naming Conventions Inconsistent #10481

willpracht opened this issue Sep 5, 2013 · 2 comments · Fixed by #10641
Labels
Milestone

Comments

@willpracht
Copy link

Looking at the new markup for Collapsibles (formerly Accordions), there's a minor inconsistency in naming:

<a class="accordion-toggle"...

Maybe this should be changed to "collapsible-toggle" for consistency. The id's used in the documentation should probably also be updated to be #collapsible1, etc.

@mofamtech
Copy link

I'm new to Bootstrap, so maybe I am missing something, but I don't see the .accordion-toggle class in the distribution bootstrap.css. I've wondered about this as it appears in the example code.

@ggam
Copy link
Contributor

ggam commented Sep 14, 2013

In fact, it seems that class isn't really needed as the example still works after removing it. I'll do a pull request for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants