Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizer variable default values not in sync w/ the LESS source #10173

Closed
saas786 opened this issue Aug 26, 2013 · 7 comments
Closed

Customizer variable default values not in sync w/ the LESS source #10173

saas786 opened this issue Aug 26, 2013 · 7 comments
Milestone

Comments

@saas786
Copy link
Contributor

saas786 commented Aug 26, 2013

Hi guys,
@container-tablet have different data on different locations, on

variables.less

@container-tablet: ((720px + @grid-gutter-width));

but on customizer

@container-tablet: 728px;

why is that?

@cvrebert cvrebert reopened this Aug 26, 2013
@cvrebert
Copy link
Collaborator

@saas786 Opening 20 separate issues on the same topic when you could have opened just 1 _is not helpful_.

@saas786
Copy link
Contributor Author

saas786 commented Aug 26, 2013

@cvrebert I believe this is what you wanted, if you would have cared to listen to my comment on my pull request #9910 I would not have opened a single issue :), I think this is what you wanted me to do that's why I spent sometime on creating small issues for each problem I found.

@cvrebert
Copy link
Collaborator

@saas786 It is good to avoid reporting multiple unrelated or only tangentially-related problems in the same issue, but on the other hand, it's bad to open many micro-issues about the same underlying problem when the fact that there is a common cause is obvious.

@cvrebert
Copy link
Collaborator

@saas786 As I said in your pull request, your pull request includes changes that I do not feel comfortable merging on my own, thus it wasn't relevant to me and I stopped paying attention to it in favor of having more senior members of the team deal with it.

@saas786
Copy link
Contributor Author

saas786 commented Aug 27, 2013

@cvrebert I have understood your standpoint yesterday, the reason I was not happy because I haven't received any hint during this week from @mdo whether he had a look at it or he is going to merge it or decline it etc. So I can get a peace of mind about whats going to happen.

I want to have hands on stable enough release so I can feel comfortable using it in my projects easily and you know better then me that v3 was already a super major release which brought almost full overhaul of the system, So if I get a hint after the initial release that there is going to be more changes (at kind of core level of bootstrap) then I don't feel comfortable using it, and its causing me trouble as nor I can't use v2 neither v3 and my projects are getting delayed because of this :(

Hope you understand my standpoint.

@cvrebert
Copy link
Collaborator

From a dupe:

@dropdown-caret-color has @dropdown-caret-color as its placeholder value rather than @link-color

@cvrebert
Copy link
Collaborator

Closing in favor of #11095.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants