You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #1007, Eyeglass support was added. This was a great improvement for us as it allowed us to pull more dependencies in through npm.
We have a sass library that works both in Rails's asset pipeline and in other ecosystems. The eyeglass import having a different name in Eyeglass unfortunately makes us choose between only supporting building through eyeglass, or not having eyeglass support and having everything else work.
For example, in Rails:
@import"bootstrap";
But in eyeglass:
@import"bootstrap-sass/bootstrap";
If you look at the README in its current state you can see how consistent it is until you get down to the Eyeglass section.
This could be fixed by adding a name field to the eyeglass section package.json for bootstrap-sass:
For consistency, I think it would be great if you could @import "bootstrap" in any ecosystem and have it work.
This would be a breaking change for anybody currently using eyeglass, but an easy fix to implement (change your import statements to "@import bootstrap").
The text was updated successfully, but these errors were encountered:
@iammikecohen I'd love to hear your input here as you championed the first pull request. There may be a historical reason for the name difference that I'm missing.
In #1007, Eyeglass support was added. This was a great improvement for us as it allowed us to pull more dependencies in through npm.
We have a sass library that works both in Rails's asset pipeline and in other ecosystems. The eyeglass import having a different name in Eyeglass unfortunately makes us choose between only supporting building through eyeglass, or not having eyeglass support and having everything else work.
For example, in Rails:
But in eyeglass:
If you look at the README in its current state you can see how consistent it is until you get down to the Eyeglass section.
This could be fixed by adding a
name
field to theeyeglass
section package.json forbootstrap-sass
:For consistency, I think it would be great if you could
@import "bootstrap"
in any ecosystem and have it work.This would be a breaking change for anybody currently using eyeglass, but an easy fix to implement (change your import statements to "@import bootstrap").
The text was updated successfully, but these errors were encountered: