Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Expr out of Boolean.Parser #7

Open
ARandomOWL opened this issue Sep 11, 2017 · 0 comments
Open

Move Expr out of Boolean.Parser #7

ARandomOWL opened this issue Sep 11, 2017 · 0 comments

Comments

@ARandomOWL
Copy link
Collaborator

ARandomOWL commented Sep 11, 2017

By the way, I think it makes sense to move the definition of Expr to Tuura.Boolean. It's strange to see it defined in Parser. Note that this may break Plato, so it will need to be fixed too.

If we move Expr to Tuura.Boolean, we get a cyclic dependency between Boolean and Boolean.Parser. Does it make sense to move Expr and its instances into Boolean.Abstract or similar, as in Plato? Also, Boolean is starting to get very cluttered with data types and instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant