Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/notification #1685

Merged
merged 4 commits into from
Nov 27, 2021
Merged

Feature/notification #1685

merged 4 commits into from
Nov 27, 2021

Conversation

Fnzero
Copy link
Collaborator

@Fnzero Fnzero commented Nov 26, 2021

No description provided.

@vercel
Copy link

vercel bot commented Nov 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/AG1mWeXrcEAxJdk8rguickDQCBps
✅ Preview: https://naive-ui-git-fork-fnzero-feature-notification-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #1685 (0ac4383) into main (49f7b4f) will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1685      +/-   ##
==========================================
+ Coverage   64.86%   64.87%   +0.01%     
==========================================
  Files         886      886              
  Lines       17163    17174      +11     
  Branches     4057     4061       +4     
==========================================
+ Hits        11132    11141       +9     
- Misses       5267     5269       +2     
  Partials      764      764              
Impacted Files Coverage Δ
src/notification/src/NotificationProvider.tsx 86.66% <60.00%> (-3.34%) ⬇️
src/notification/src/NotificationContainer.tsx 90.00% <100.00%> (ø)
src/notification/src/styles/index.cssr.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f7b4f...0ac4383. Read the comment docs.

@07akioni
Copy link
Collaborator

image

这块处理的不好

@07akioni 07akioni merged commit 297aaae into tusen-ai:main Nov 27, 2021
@07akioni
Copy link
Collaborator

max 那块写的太糙了,动画都整没了。

ref 15eb953

@Fnzero
Copy link
Collaborator Author

Fnzero commented Nov 29, 2021

max 那块写的太糙了,动画都整没了。

ref 15eb953

好的,后面修一下

@Fnzero
Copy link
Collaborator Author

Fnzero commented Nov 29, 2021

这个是指?

@07akioni
Copy link
Collaborator

这个是指?

我已经改好了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Message & Notification): global configuration and global events
2 participants