Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date picker props 'clearable' should also affect the button 'clear' in popover #1196

Closed
Hawods opened this issue Sep 18, 2021 · 2 comments · Fixed by #3168
Closed

Date picker props 'clearable' should also affect the button 'clear' in popover #1196

Hawods opened this issue Sep 18, 2021 · 2 comments · Fixed by #3168
Labels
feature request New feature or request

Comments

@Hawods
Copy link
Contributor

Hawods commented Sep 18, 2021

This function solves the problem (这个功能解决的问题)

If clearable = false, it means we don't want user to clear the value of picker, no matter how.

Expected API (期望的 API)

No new API needed.
@github-actions github-actions bot added the feature request New feature or request label Sep 18, 2021
@LYErin
Copy link
Contributor

LYErin commented Sep 21, 2021 •
edited
Loading

clearable 只是清除输入框的日期值， 不需要弹出框的清除按钮，按钮自行通过actions控制

@07akioni
Copy link
Collaborator

clearable 只是清除输入框的日期值， 不需要弹出框的清除按钮，按钮自行通过actions控制

我其实在想这两个要不要关联，毕竟 clearable 这个行为需要一致，我们说不 clearable 其实一定程度是想说值选了就删除不了

@XieZongChen XieZongChen mentioned this issue Jun 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@Hawods @07akioni @LYErin