Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go modules turnerlabs #39

Closed

Conversation

bdharris08
Copy link

REF: #37

Proposal:
Switch to using go modules.

If using Go 1.18, we can use this to install:

go install github.com/turnerlabs/fargate-create@latest

@awlawl awlawl self-requested a review April 20, 2022 00:58
@awlawl
Copy link
Contributor

awlawl commented Apr 20, 2022

Thanks for the contribution, I will try to get this reviewed this week.

I assume you are not an employee of Warner Media/Warner Bros Discovery, correct?

@bdharris08
Copy link
Author

Correct.

Copy link
Contributor

@awlawl awlawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build using the new system with go 1.18.1. I verified on a Monterey system that the original binary was crashing and that a new build works.

We are just about to roll out a new way for outside contributors to contribute to our open source projects. When that is ready I will let you know and then I can merge.

Thanks again

@awlawl
Copy link
Contributor

awlawl commented Apr 26, 2022

@bdharris08

So we have our open source agreement working. It will create a line in the PR "Checks" section that you will need to click on, read and then agree to.

Unfortunately since we didn't have turned on for this repo when you submitted, you might have to resubmit the PR. If thats the case: Push it up again, open a new PR, Agree to the terms and I will merge asap.

Sorry to make you do this, we just rolled out this process this week so you might be one of the first to contribute.

@bdharris08
Copy link
Author

@awlawl That's ok, I submitted this PR to be helpful. It can be easily re-created by your team as per your earlier comment. I'll go ahead and close this and leave the change for your team to implement.
You can find more information about go modules here: https://go.dev/blog/migrating-to-go-modules

@bdharris08 bdharris08 closed this Apr 26, 2022
@bdharris08 bdharris08 deleted the go-modules-turnerlabs branch April 26, 2022 17:30
@awlawl
Copy link
Contributor

awlawl commented Apr 26, 2022

Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants