-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ChatML format to chat.py #86
Conversation
I just saw that with |
Reopening: My ChatML works for the tinyllama model, the orca somehow doesn't: orca:
chatml:
I really don't know why though (the code formatting issues are because I did not use the fix: #81 ) |
ChatML is also not perfect
But I can't tell if that's the 3.0bpw's fault, the model's fault or the prompt templates fault |
Yeah, I'm reworking the chat script a bit, separating out the prompt formats to another module to make it easier to expand on. But I'm also struggling with TinyLlama. It should be ChatML format, and it has the extra tokens defined, so prompting it exactly like MistralOrca should work. But it's just outputting nonsense. I'll keep fighting with it, though. |
Actually I think I figured it out. It works if you disregard the extra tokens and just encode the |
Ahh okay 😊 When the TinyLlama model will be done with pretraining, I suppose it will eventually be finetuned correctly |
I tested this model https://huggingface.co/acalatrava/TinyLlama-1.1B-orca-gpt4 at 3.0bpw and it seems to work fine with the chatml format. I however noticed that with chatml/tinyllama format it was able to output <|im_start|>, I think it would be good to include all special delimiters in the stop conditions
|
I added the
ChatML
format tochat.py
in order to use the new TinyLlama chat finetune.Here is my quantization (alpaca calibration dataset used):
https://huggingface.co/SinanAkkoyun/TinyLlama-1.1B-Chat-v0.3-exl2
I commented out the naming schemes because with them, the 1.1B model does not behave correctly.