Replace CSS parser with postcss #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdsutherland
commented
Sep 6, 2020
| var source = rule.source; | ||
| source.start.line--; | ||
| source.start.column--; | ||
| source.end.column++; |
There was a problem hiding this comment.
I didn't fully understand why this was done previously so I made this equivalent.
https://www.npmjs.com/package/css doesn't support newer CSS features
jdsutherland
force-pushed
the
postcss
branch
from
2737c6b to
93a7e0a
Compare
turbio
approved these changes
Sep 12, 2020
|
@turbio the issue still persists because csslint doesn't support newer CSS syntax. This PR merge is progress but doesn't have much effect without addressing the linting (it also blows up). What are your thoughts? |
|
@jdsutherland gotcha, I'll re-open the issue. I'm thinking the best path forward is to update the linter as well (assuming that's easy). I forget the specifics of how linting works in Bracey but for the current purpose it might be sufficient to also use the postcss parser for error checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #36.
https://www.npmjs.com/package/css doesn't support newer CSS features. When encountering newer CSS like CSS3 variables or certain grid syntax, the server blows up because the parser returns undefined.
postcssdoesn't have this issue.There is an additional wrinkle here as mentioned in #36:
so with this PR, the parsing works but csslint will still cause bracey to blow up.
It looks like csslint is dead (see CSSLint/csslint#720), so the solution appears to be either replace it with stylelint or simply remove csslint from bracey.
I'm not sure this PR will get any response but if there is interest, we can discuss the linting issues.