Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning channels and streams #2

Open
mcollina opened this issue Sep 12, 2014 · 0 comments
Open

Returning channels and streams #2

mcollina opened this issue Sep 12, 2014 · 0 comments

Comments

@mcollina
Copy link
Collaborator

We need a way from a Seneca service to return a binary stream and a channel.

Currently, it's really easy to add a binary stream inside the seneca response. However, the same is not true for channels, as you need to create those from another channel. Currently I'm trying to figure out if it make sense if streams in objectMode should be auto-piped as channels, but it has its own issues: GraftJS/jschan#26

In graft, we pass the channel and the session in the message as non-enumerable properties. You might want to depend on graft directly to just reuse that code (it's also simpler to use).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant