Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign commit after absorb #122

Closed
lcheylus opened this issue Sep 29, 2024 · 2 comments
Closed

Sign commit after absorb #122

lcheylus opened this issue Sep 29, 2024 · 2 comments

Comments

@lcheylus
Copy link

lcheylus commented Sep 29, 2024

Thanks for your great tool, I just discovered it. Very useful for my Git workflows with fixes + rebase/fixup 👍

Usually, I sign all my commits on GitHub (with a dedicated SSH key) via git -s -S commit.

When using the "Fixup workflow" (first commit with signature => fix => 2nd commit => rebase/fixup => commit to squash the 2 commits) as abstracted by "absorb", the signature is lost after rebase. I re-sign my commits after rebase via git rebase --exec "git commit --amend --no-edit -n -S -s" -i <commit_hash>.

Could you add an option for git-absorb to do the same thing? => -s = sign commit after absorb.

@tummychow
Copy link
Owner

git rebase has a flag to sign commits - -S, as usual. for my stance on supporting these arguments in git-absorb, see #88. if you want custom flags for your git rebase, my advice would be to invoke rebase yourself, which absorb has always been designed to support

@lcheylus
Copy link
Author

TIL rebase can sign commits with -S flag !

Thanks for your explanations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants