Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has 10Gb interface #545

Closed
michaeljs1990 opened this issue May 15, 2017 · 2 comments
Closed

Has 10Gb interface #545

michaeljs1990 opened this issue May 15, 2017 · 2 comments
Assignees

Comments

@michaeljs1990
Copy link
Contributor

michaeljs1990 commented May 15, 2017

If you have a card with only a 40Gb interface on it this is false. This may be the correct thing to do but would anyone oppose to adding a "Has 40Gb interface" tag to assets?

@byxorna
Copy link
Contributor

byxorna commented May 18, 2017

@michaeljs1990 I think we should support arbitrary (read: dynamic nic classifications). I think it would be sweet to auto-infer classification, and do some rounding to make things look right, so a nic reporting 999999kbps in LSHW is reported as a 10g nic, and perhaps even expose interface (ethernet/IB) as well. Thoughts?
I think this will be more extensible if instead of relying on booleans (has 10g/has 40g, which gets confusing when 40g is a superset of 10g for some requirements), we should rely on numerics (i.e. at least 10g capacity, at least 40g capacity)

@byxorna
Copy link
Contributor

byxorna commented May 20, 2017

Ive opened #548 to address this. I thought it would have been more complicated, but this is only a small tweak to the show overview page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants