-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon for TMTumblrActivity becomes black on IOS8 #68
Comments
Thanks @ahem – to be honest I'm wondering if its even worth keeping the custom Tumblr for iOS is now iOS 8 only and its likely that the next major update to |
Yeah, I know. We have also stopped using this code after the Tumblr extension came out, so I guess you are right that the custom UIActivity more or less has had it's time. |
I think that UIActivity support should be kept at least for now. Since iOS 7 and previous devices still exist , so we app developers should make our apps support for these devices. Actually I am wondering if that mean we should abandon uiactivity in our future development since share extension is launched now in iOS 8? |
You can always you a previous version of the SDK if you require the UIActivity support |
It is not so cool if we have to involve more than one version of SDK in our app to support both iOS 7 and 8 |
Understood. That said, the utility of this class is very small (only 35 lines, almost all of which is boilerplate). I think it's reasonable to ask people to just include the |
IOS8 allows color icons for custom UIActivities, but it does so in a way that is not backwards compatible with the icons that should be use for UIActivities in IOS7.
For IOS7 the color information for an icon was discarded, and only the alpha value was shown in grayscale. For IOS8, color information is used and alpha is shown as black. So, unless the colored icon should have a black background, the same icon cannot be used for IOS7 and IOS8.
It would be great if you could implement a
[[UIDevice currentDevice] hasSystemVersionGreaterThanOrEqualTo:@"8.0"]
check (or something similar) and return a colored icon for IOS8.The text was updated successfully, but these errors were encountered: