Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for out_of_range error when accessing targetIndices with a non-targeted bb due to a cascading problem in distance #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kd610
Copy link
Collaborator

@kd610 kd610 commented Nov 14, 2024

This fixes handling of the issue mentioned in #28.

If you want to make it shorter but sacrifice a bit of readability, we could go with the code below as well.

uint32_t distance = (rawDistance > 0.0 && rawDistance < 1.0) ? 1 : (uint32_t)(rawDistance);

Please let me know your thoughts.

@kd610 kd610 requested a review from sphl November 14, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant