Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink create_model input handling. #31

Open
lnksz opened this issue Aug 24, 2017 · 0 comments
Open

Rethink create_model input handling. #31

lnksz opened this issue Aug 24, 2017 · 0 comments

Comments

@lnksz
Copy link
Contributor

lnksz commented Aug 24, 2017

Now create_model changes the input parameters data, edge, vertex directly.
This is kind of a tolerable side-effect until these are not reused after the specific run.

Changes:

  • data dict gets extended with hubs, vertex and edge keys.
  • vertex and edge get reindexed.

Alternatives:

  • Handle both formats. 🥇
  • Do not have this side-effect and await the DataFrames in a well-defined format. 🥈
    • needs a review of the data preparation process at the beginning of create_model esp. at m.peak
  • Operate on a local copy of the parameter and change it as it is now done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant