fix(widget)!: List should not ignore empty string items #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayanarijit
suggested changes
Feb 14, 2023
mindoodoo
approved these changes
Feb 16, 2023
|
This branch needs to be rebased on the latest main branch so that newer version of Rust compiler will be used and it will fix the issue on compiling |
|
Rebased. |
rhysd
approved these changes
Feb 17, 2023
sayanarijit
suggested changes
Feb 17, 2023
|
Updated. |
|
But this looks like a breaking change. Some users might be using this bug/feature as a condition, So, let's wait for a major release? |
|
Since crossterm was updated from 0.25 to 0.26 and MSRV was bumped from 1.56 to 1.59, the next release is already a major release (0.20.0?) if my understanding is correct. |
|
Ah, good point. |
sayanarijit
approved these changes
Feb 17, 2023
mindoodoo
approved these changes
Feb 18, 2023
mindoodoo
changed the title
mindoodoo
changed the title
sayanarijit
added a commit
that referenced
this pull request
Mar 3, 2023
Fixes issue #680. Handles the case where a list item is created with an empty string, which is not split by the lines iterator. Co-authored-by: Collin O'Connor <[email protected]> Co-authored-by: Arijit Basu <[email protected]> Co-authored-by: Arijit Basu <[email protected]>
kdheepak
added
the
Type: Breaking Change
joshka
pushed a commit
that referenced
this pull request
Feb 5, 2025
## 🤖 New release * `ratatui-macros`: 0.3.0 -> 0.3.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.3.1](ratatui/ratatui-macros@v0.3.0...v0.3.1) - 2024-05-13 ### Added - Better error messages for `span!` macro ([#43](ratatui/ratatui-macros#43)) ### Fixed - downgrade ratatui to 0.26.2 ([#41](ratatui/ratatui-macros#41)) ### Other - Update authors to ratatui developers ([#44](ratatui/ratatui-macros#44)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #680. Handles the case where a list item is created with an empty string, which is not split by the
linesiterator.Testing guidelines
New test can be ran with
cargo testChecklist