feat(barchart) set custom text value in the bar #309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again 😸
somehow I missed this feature, while integrating the new code. (In my original PR #288, I had a function pointer, which formats the values.
format: fn(u64) -> String
).This patch suggests adding a new function
text_value
to theBar
, which will override the default text valueCommit message:
for now the value is converted to a string and then printed. in many cases the values are too wide or double values. so it make sense to set a custom value text instead of the default behavior.
this patch suggests to add a method
fn text_value(mut self, text_value: String)
to the Bar, which allows to override the value printed in the bar