Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prelude): add a prelude #304

Merged
merged 1 commit into from
Jul 10, 2023
Merged

feat(prelude): add a prelude #304

merged 1 commit into from
Jul 10, 2023

Conversation

joshka
Copy link
Member

@joshka joshka commented Jul 9, 2023 •
edited
Loading

This allows users of the library to easily use ratatui without a huge amount of imports

Review hints:

  • The main change is lib.rs
  • I'm curious whether the aliasing decisions make sense (BlockTitle, CanvasLine, etc.)
  • Are there any types included in the prelude that are too generic and clash with commonly used rust types?

@codecov
Copy link

codecov bot commented Jul 9, 2023 •
edited
Loading

Codecov Report

Merging #304 (2e29558) into main (a1813af) will not change coverage.
The diff coverage is n/a.

❗ Current head 2e29558 differs from pull request most recent head c49c665. Consider uploading reports for the commit c49c665 to get more accurate results

@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   83.11%   83.11%           
=======================================
  Files          37       37           
  Lines        7717     7717           
=======================================
  Hits         6414     6414           
  Misses       1303     1303
Impacted Files Coverage Δ
src/lib.rs 100.00% <ø> (ø)
src/widgets/block.rs 86.10% <ø> (ø)

@joshka
feat(prelude): add a prelude
c49c665 
This allows users of the library to easily use ratatui without a huge amount of imports
@joshka
Copy link
Member Author

joshka commented Jul 9, 2023

(added StatefulWidget)

orhun
orhun approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@joshka joshka added this pull request to the merge queue Jul 10, 2023
Merged via the queue into ratatui:main with commit 804115a Jul 10, 2023
@joshka joshka deleted the feat-prelude branch July 10, 2023 22:59
a-kenji pushed a commit to a-kenji/ratatui that referenced this pull request Jul 16, 2023
@joshka @a-kenji
feat(prelude): add a prelude (ratatui#304)
e2c91bf 
This allows users of the library to easily use ratatui without a huge amount of imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

@mindoodoo mindoodoo Awaiting requested review from mindoodoo

@sayanarijit sayanarijit Awaiting requested review from sayanarijit

@sophacles sophacles Awaiting requested review from sophacles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshka @orhun