-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stylize): allow all widgets to be styled #289
Conversation
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 83.85% 85.00% +1.15%
==========================================
Files 38 38
Lines 8045 8464 +419
==========================================
+ Hits 6746 7195 +449
+ Misses 1299 1269 -30
|
I thought we were putting macro code behind |
Yep. Just user facing macros makes sense. Here they cut down on hundreds of LoC so that’s really useful. |
5277c79
to
e8a95d3
Compare
(rebased on main) |
e8a95d3
to
42d5432
Compare
42d5432
to
2b4ea4d
Compare
Rebased on main to resolve conflicts with prelude introduction and barchart changes (barchart.rs -> barchart/mod.rs). |
5373442
to
b24c82e
Compare
This is cool... |
- Add styled impl to: - Barchart - Chart (including Axis and Dataset), - Guage and LineGuage - List and ListItem - Sparkline - Table, Row, and Cell - Tabs - Style - Allow modifiers to be removed (e.g. .not_italic()) - Allow .bg() to recieve Into<Color> - Made shorthand methods consistent with modifier names (e.g. dim() not dimmed() and underlined() not underline()) - Simplify integration tests - Add doc comments - Simplified stylize macros with https://crates.io/crates/paste
Runny clippy first means that we fail fast when there is an issue that can easily be fixed rather than having to wait 30-40s for the failure
b24c82e
to
49152db
Compare
Fixed up doc tests problem that I introduced by adding more docs. |
* feat(stylize): allow all widgets to be styled - Add styled impl to: - Barchart - Chart (including Axis and Dataset), - Guage and LineGuage - List and ListItem - Sparkline - Table, Row, and Cell - Tabs - Style - Allow modifiers to be removed (e.g. .not_italic()) - Allow .bg() to recieve Into<Color> - Made shorthand methods consistent with modifier names (e.g. dim() not dimmed() and underlined() not underline()) - Simplify integration tests - Add doc comments - Simplified stylize macros with https://crates.io/crates/paste * build: run clippy before tests Runny clippy first means that we fail fast when there is an issue that can easily be fixed rather than having to wait 30-40s for the failure
This PR:
Stylize
implementations for all the remaining widgetsStyle::new().blue()
Style::new().not_bold()
Details:
dimmed() and underlined() not underline())