Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve CONTRIBUTING.md #277

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Conversation

joshka
Copy link
Member

@joshka joshka commented Jun 25, 2023

No description provided.

@joshka
Copy link
Member Author

joshka commented Jun 25, 2023

Note - there is intentional repetition in this doc. It's intended as people often only read the section that they care about.

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #277 (3dc40f7) into main (f7c4b44) will decrease coverage by 0.47%.
The diff coverage is n/a.

❗ Current head 3dc40f7 differs from pull request most recent head 1e82181. Consider uploading reports for the commit 1e82181 to get more accurate results

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   82.97%   82.50%   -0.47%     
==========================================
  Files          37       36       -1     
  Lines        7500     7301     -199     
==========================================
- Hits         6223     6024     -199     
  Misses       1277     1277              

see 9 files with indirect coverage changes

CONTRIBUTING.md Outdated Show resolved Hide resolved
@joshka joshka force-pushed the docs-contributing branch 2 times, most recently from 1ae8905 to ae60781 Compare June 26, 2023 00:17
@joshka joshka requested a review from orhun June 26, 2023 00:44
@joshka
Copy link
Member Author

joshka commented Jun 26, 2023

Fixed link to cargo-make and typos

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lthoerner lthoerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a great writeup.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
lthoerner

This comment was marked as duplicate.

@joshka joshka force-pushed the docs-contributing branch 2 times, most recently from 06fa202 to 6284706 Compare July 3, 2023 22:35
@joshka
Copy link
Member Author

joshka commented Jul 3, 2023

All mentioned feedback incorporated.

@joshka joshka requested review from mindoodoo and lthoerner July 3, 2023 22:36
@joshka joshka force-pushed the docs-contributing branch from 6284706 to ab46043 Compare July 4, 2023 21:49
@joshka joshka force-pushed the docs-contributing branch from ab46043 to 1e82181 Compare July 8, 2023 10:32
@orhun orhun added this pull request to the merge queue Jul 8, 2023
Merged via the queue into ratatui:main with commit 0833c90 Jul 8, 2023
@joshka joshka deleted the docs-contributing branch July 9, 2023 02:14
a-kenji pushed a commit to a-kenji/ratatui that referenced this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants