-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(benchmarks): add criterion benchmarks for paragraph #262
Conversation
Codecov Report
@@ Coverage Diff @@
## main #262 +/- ##
=======================================
Coverage 81.76% 81.76%
=======================================
Files 34 34
Lines 6591 6591
=======================================
Hits 5389 5389
Misses 1202 1202 |
Note that the lint on this is related to pulling in fakeit which pulls in an old version of the time crate via chrono. I've submitted a PR to fix the issue in The cargo deny issue is resolved by the PR.
|
To run the benchmarks: cargo bench And then open the generated `target/criterion/report/index.html` in a browser. - add the BSD 2 clause and ISC licenses to the `cargo deny` allowed licenses list (as a transitive dependency of the `fakeit` crate). - remove the WTFPL license from the `cargo deny` allowed licenses list as it is unused and causes a warning when running the check.
Fixed the lint issue in deny.toml by adding compatible licenses (BSD 2 clause and ISC) and removing WTFPL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
To run the benchmarks: cargo bench And then open the generated `target/criterion/report/index.html` in a browser. - add the BSD 2 clause and ISC licenses to the `cargo deny` allowed licenses list (as a transitive dependency of the `fakeit` crate). - remove the WTFPL license from the `cargo deny` allowed licenses list as it is unused and causes a warning when running the check.
To run the benchmarks:
And then open the generated
target/criterion/report/index.html
in abrowser.