Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(example): remove redundant vec![] in user_input example #26

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

orhun
Copy link
Member

@orhun orhun commented Feb 12, 2023

Upstream: #631

Description

I found vec![] is redundant in user_input example. This PR removes it.

Testing guidelines

I ran cargo run --example user_input and tried to change the edit mode, edit the input, and add some lines to messages pane. It worked fine.

Checklist

  • I have read the contributing guidelines.
  • I have added relevant tests. (No tests for the example)
  • I have documented all new additions. (No document for the example)

@mindoodoo mindoodoo added the Type: Documentation Improvements or additions to documentation label Feb 14, 2023
Copy link
Member

@sayanarijit sayanarijit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good.

@sayanarijit sayanarijit requested a review from mindoodoo March 3, 2023 03:32
@mindoodoo mindoodoo changed the title Remove redundant vec![] in user_input example refactor(example): remove redundant vec![] in user_input example Mar 25, 2023
@mindoodoo mindoodoo merged commit 62930f2 into main Mar 25, 2023
@joshka joshka deleted the 631/redundant-vec branch July 4, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants