Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ci): simplify cargo-make installation #240

Merged
merged 8 commits into from
Jun 12, 2023
Merged

refactor(ci): simplify cargo-make installation #240

merged 8 commits into from
Jun 12, 2023

Conversation

orhun
Copy link
Member

@orhun orhun commented Jun 11, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 11, 2023 •
edited
Loading

Codecov Report

Merging #240 (34bbaaf) into main (492af7a) will not change coverage.
The diff coverage is n/a.

❗ Current head 34bbaaf differs from pull request most recent head 6d9d65b. Consider uploading reports for the commit 6d9d65b to get more accurate results

@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files          34       34           
  Lines        6591     6591           
=======================================
  Hits         5389     5389           
  Misses       1202     1202
Impacted Files Coverage Δ
src/backend/crossterm.rs 0.00% <ø> (ø)
src/backend/mod.rs 33.33% <ø> (ø)
src/backend/termion.rs 28.04% <ø> (ø)
src/backend/termwiz.rs 0.00% <ø> (ø)
src/backend/test.rs 43.63% <ø> (ø)
src/buffer.rs 93.30% <ø> (ø)
src/layout.rs 85.25% <ø> (ø)
src/style.rs 85.33% <ø> (ø)
src/terminal.rs 56.19% <ø> (ø)
src/text.rs 69.74% <ø> (ø)
... and 14 more

@orhun orhun marked this pull request as draft June 11, 2023 15:15
@joshka joshka self-requested a review June 11, 2023 20:35
@orhun orhun marked this pull request as ready for review June 12, 2023 23:20
@orhun orhun added this pull request to the merge queue Jun 12, 2023
Merged via the queue into ratatui:main with commit 0bf6af1 Jun 12, 2023
samyosm pushed a commit to samyosm/ratatui that referenced this pull request Jun 18, 2023
@orhun @samyosm
refactor(ci): simplify cargo-make installation (ratatui#240)
973fd2e 
* refactor(ci): simplify cargo-make installation

* chore(ci): use the latest version of cargo-make

* refactor(ci): remove unused triple values

* chore(ci): list all steps before ci

* fix(ci): checkout the repository

* refactor(ci): remove unnecessary os variables

* refactor(ci): use dtolnay/rust-toolchain action
@joshka joshka mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshka joshka joshka approved these changes

@sophacles sophacles Awaiting requested review from sophacles

@mindoodoo mindoodoo Awaiting requested review from mindoodoo

@sayanarijit sayanarijit Awaiting requested review from sayanarijit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhun @joshka