Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typos): configure typos linter #233

Merged
merged 1 commit into from
Jun 10, 2023
Merged

fix(typos): configure typos linter #233

merged 1 commit into from
Jun 10, 2023

Conversation

joshka
Copy link
Member

@joshka joshka commented Jun 9, 2023

  • Adds a new typos.toml
  • Prevents ratatui from being marked as a typo of ratatouille
  • Changes paragraph tests so that the truncated word is a valid word

- Adds a new typos.toml
- Prevents ratatui from being marked as a typo of ratatouille
- Changes paragraph tests so that the truncated word is a valid word
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #233 (5242ef2) into main (d711f2a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files          34       34           
  Lines        6579     6581    +2     
=======================================
+ Hits         5374     5376    +2     
  Misses       1205     1205           
Impacted Files Coverage Δ
src/widgets/paragraph.rs 99.81% <100.00%> (+<0.01%) ⬆️

@a-kenji
Copy link
Contributor

a-kenji commented Jun 10, 2023

Suggestion/nit: I prefer to have such files prefixed with a dot.

So:

mv typos.toml .typos.toml

Maybe other people feel the same way.

@joshka
Copy link
Member Author

joshka commented Jun 10, 2023

Suggestion/nit: I prefer to have such files prefixed with a dot.

So:

mv typos.toml .typos.toml

Maybe other people feel the same way.

I wasn’t sure about that, but went with consistency with the other config files. I’m open to either way. Happy to take a PR for it.

@joshka joshka merged commit ef4d743 into ratatui:main Jun 10, 2023
@joshka joshka deleted the typos branch June 10, 2023 23:31
samyosm pushed a commit to samyosm/ratatui that referenced this pull request Jun 18, 2023
- Adds a new typos.toml
- Prevents ratatui from being marked as a typo of ratatouille
- Changes paragraph tests so that the truncated word is a valid word
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants