-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): add contributors graph image #225
Conversation
Codecov Report
@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 81.68% 81.68%
=======================================
Files 34 34
Lines 6579 6579
=======================================
Hits 5374 5374
Misses 1205 1205 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of like the idea of potentially keeping the acknowledgement section in addition to the contributors section. What do you think ?
The idea being we can keep special acknowledgements in the acknowledgement section, such as the logo creator, the og maintainer, etc...
The info is there. Just the section name is changed to fit both the image and acknowledgments underneath. Oops. I'm wrong :) |
I agree with @mindoodoo, let's keep the acknowledgements section. |
- Add contributors graph - Add markdownlint config file - Reformat README line width to 100 - Add a link to the CHANGELOG - Remove APPS.md - Change apps link to the Wiki instead of APPS.md
I moved it back in to an acknowledgment section, reformated to 100 columns, added a markdownlint config, changed the link to the APPs wiki page, removed APPS.md, and added a link to the CHANGELOG (it's always useful being able to find that from the crates.io page). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks !
No description provided.