-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: reformat imports #219
Conversation
Codecov Report
@@ Coverage Diff @@
## main #219 +/- ##
=======================================
Coverage 81.76% 81.76%
=======================================
Files 34 34
Lines 6591 6591
=======================================
Hits 5389 5389
Misses 1202 1202
|
Looks like it will create merge conflict with other PRs. LGTM, otherwise. |
Yup. I figured that a rebase would be necessary depending on which PR goes first regardless. |
I guess it's easy to force rebase this pr than other prs, so let's wait for a good opportunity. |
I'm not sure I'd worry too much about waiting - there's always going to be some amount of outstanding PRs, so there's not really a good or a bad time to merge cross repo type stuff. This contains a rustfmt.toml change that make all the changes automatic. There are 2 ways to make the pain of rebasing on top of this pain free (assuming this change gets merged before some other PR):
Option 1 would be mostly automatic. |
Order imports by std, external, crate and group them by crate
Rebased and fixed conflict in |
Order imports by std, external, crate and group them by crate
Order imports by std, external, crate and group them by crate