-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: lint and doc cleanup #191
Conversation
1a17e25
to
7ebdd0a
Compare
I notice a bunch of checks are failing on this. It looks like this change effectively ignores a bunch of places that could be better written. I wonder if it would be worth leaving the lints for those on rather than ignoring them, with a goal to fix the issues rather than ignore them. |
ok, makes sense, i removed the clippy changes for now |
Wasn't exactly sure for the conventional commit (PR title) as this is both linting and a couple doc fixes so marked it as unscoped chore, maintainers feel free to change it to something more adequate if you have any ideas. |
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 81.63% 81.66% +0.02%
==========================================
Files 34 34
Lines 6574 6572 -2
==========================================
Hits 5367 5367
+ Misses 1207 1205 -2
|
chore is fine. I made the changes that we both suggested (just used _n instead of a lint exception) |
@joshka were the Cargo.toml changes intentional? |
A few more minor cleanups, mostly in documentation
Ah, I see - you moved the indoc into dependencies because of the format usage, plus sorted them. Slightly outside of the initial scope, but sure, not a biggie :) I removed the no-longer-needed comment about the underscore, and rebased on main |
A few more minor cleanups, mostly in documentation