test(widget): add unit tests for Paragraph #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @TimerErTim for a review |
|
Force pushed formatting fixes |
This was referenced Apr 29, 2023
TimerErTim
reviewed
Apr 29, 2023
orhun
reviewed
Apr 30, 2023
|
Rebased on #161 to use |
orhun
approved these changes
May 4, 2023
orhun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this in place to help ensure #149 doesn't break anything.
I wasn't 100% certain how the
zero_width_char_at_end_of_linetest was supposed to actually fail / not-fail as there's no assertion. Rewrote it to conform to the pattern of the other tests (but perhaps @orhun and @rhysd can add a bit more context if this is incorrect?