Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(examples): refactor paragraph example #152

Merged
merged 3 commits into from
Apr 27, 2023
Merged

refactor(examples): refactor paragraph example #152

merged 3 commits into from
Apr 27, 2023

Conversation

mindoodoo
Copy link
Member

While looking at #33 I opened the paragraph example and almost lost my eyesight with the white background haha. So anyways this PR brings minor tweaks aiming to make the example easier on the eyes, as well as a couple minor changes.

Changes :

  • Background color not set anymore
  • Text foreground color changed to gray (seemed like the most sensible option that would suit both light and dark theme users)
  • Moved scroll example to last chunk
  • Reworked block names

@mindoodoo mindoodoo added the Type: Enhancement New feature or request label Apr 27, 2023
@mindoodoo mindoodoo requested review from sayanarijit and orhun April 27, 2023 09:24
@mindoodoo mindoodoo changed the title Refactor paragraph example refactor(examples): refactor paragraph example Apr 27, 2023
@mindoodoo mindoodoo merged commit 26cf1f7 into ratatui:main Apr 27, 2023
@joshka joshka mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

@sayanarijit sayanarijit sayanarijit approved these changes

Assignees
No one assigned
Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mindoodoo @sayanarijit @orhun