Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing whitespace in url() #20

Closed
siwinski opened this issue Oct 1, 2014 · 5 comments
Closed

Removing whitespace in url() #20

siwinski opened this issue Oct 1, 2014 · 5 comments

Comments

@siwinski
Copy link

siwinski commented Oct 1, 2014

Came across this issue when using the Drupal module advagg:

Raw:
filter: url("data:image/svg+xml;utf8,<svg xmlns=\'http://www.w3.org/2000/svg\'><filter id=\'grayscale\'><feColorMatrix type=\'matrix\' values=\'0.3333 0.3333 0.3333 0 0 0.3333 0.3333 0.3333 0 0 0.3333 0.3333 0.3333 0 0 0 0 0 1 0\'/></filter></svg>#grayscale")

Compressed:
filter:url("data:image/svg+xml;utf8,<svgxmlns='http://www.w3.org/2000/svg'><filterid='grayscale'><feColorMatrixtype='matrix'values='0.33330.33330.3333000.33330.33330.3333000.33330.33330.33330000010'/></filter></svg>#grayscale");

Sample write-ups/examples about usage:

@ordinarywebguy
Copy link

I'm also getting this issue. Please fix. Thanks!

@siwinski
Copy link
Author

While I would still like to see this issue fixed, you can get around it by specifying the filter this way:

filter: url("data:image/svg+xml;utf8,<svg%20xmlns=\'http://www.w3.org/2000/svg\'><filter%20id=\'grayscale\'><feColorMatrix%20type=\'matrix\'%20values=\'0.3333,0.3333,0.3333,0,0,0.3333,0.3333,0.3333,0,0,0.3333,0.3333,0.3333,0,0,0,0,0,1,0\'/></filter></svg>#grayscale");

@mrclay
Copy link

mrclay commented Mar 16, 2016

It sounds like extract_data_urls() is failing by considering space as terminating the string rather than capturing the full URL value.

@tubalmartin
Copy link
Owner

I have a fix for this one. Will release this week. Thank you for reporting.

@tubalmartin
Copy link
Owner

Fixed in v2.4.8-p7 release. Thank you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants