Removed paramOrder fallback

ttekglobal · Jan 6, 2021 · a0c1c0e · a0c1c0e
1 parent 4952605
commit a0c1c0e
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/client/app/services/dashboard.js b/client/app/services/dashboard.js
@@ -142,7 +142,6 @@ function transformSingle(dashboard) {
     dashboard.widgets = prepareDashboardWidgets(dashboard.widgets);
   }
   dashboard.publicAccessEnabled = dashboard.public_url !== undefined;
-
   return dashboard;
 }
 
@@ -216,10 +215,6 @@ Dashboard.prototype.getParametersDefs = function getParametersDefs() {
     })
   );
 
-  if (!_.isArray(this.options.globalParamOrder)) {
-    this.options.globalParamOrder = _.map(resultingGlobalParams, "name");
-  }
-
   // order dashboard params using paramOrder
   return _.sortBy(resultingGlobalParams, param =>
     _.includes(this.options.globalParamOrder, param.name)

diff --git a/client/app/services/widget.js b/client/app/services/widget.js
@@ -240,10 +240,6 @@ class Widget {
       }
     );
 
-    if (!isArray(this.options.paramOrder)) {
-      this.options.paramOrder = map(localParameters, "name");
-    }
-
     // order widget params using paramOrder
     return sortBy(localParameters, param =>
       includes(this.options.paramOrder, param.name)