add DataStructures dependency ?

[bjarthur]

for the [S]ort method added in #28 to work on Dicts, one must import DataStructures. should we add this to Eyeball's Project.toml to make it easier for users?

[tshort]

I find this odd. Why does sort(d::Dict) return a OrderedCollections.OrderedDict? It doesn't look like either OrderedCollections or DataStructures is a standard package.

Also, eye(foo) seems to work for me in Julia v1.7.1 and v1.8.3 without the import DataStructures. Am I missing something?

[bjarthur]

sort(Dict("a"=>1)) in a fresh julia session returns a MethodError for me. i'm pretty sure you have to import DataStructures for this to work, for as you said, it's not a stdlib. hence this issue, of whether we should add it as a dep to eyeball.

[tshort]

It looks like Revise.jl depends on OrderedCollections. That's why sort(Dict("a"=>1)) works for me by default. But, why should it? Isn't that type piracy if the package is defining Base.sort for a Dict?

[tshort]

Also, at least for OrderedCollections, that type piracy is deprecated:

https://github.com/JuliaCollections/OrderedCollections.jl/blob/844098f75f13375642b9d2bf4efdf08c691403a7/src/dict_sorting.jl#L21