Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining with undo/redo #12

Open
BrianHanechak opened this issue Apr 6, 2017 · 1 comment
Open

Combining with undo/redo #12

BrianHanechak opened this issue Apr 6, 2017 · 1 comment

Comments

@BrianHanechak
Copy link

Any thoughts on how this should be integrated with an undo/redo manager? My application is currently using an undo/redo manager for only one part of it's larger state object. It would be nice to have batched action not create two items in the undo history.

I think my current application may not have an issue because I generally want to batch one action that makes changes to undo/redo with other actions that do not.

@tshelburne
Copy link
Owner

Can you describe your use-case a little more specifically? It's hard to make a general statement because batching can be done for a number of reasons.

In my projects, I use batching only for domain purposes - in other words, when the multiple changes taking place are a single semantic update, even if it takes running multiple reductions. In that case, undo / redo is philosophically the same, and the implementation depends on how your undo / redo functionality is handled.

Sometimes though, I can imagine batching actions simply for the purposes of performance, and that might not lend itself as nicely to undo / redo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants