Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Support fastify #932

Open
1 of 15 tasks
Romakita opened this issue Sep 20, 2020 · 9 comments
Open
1 of 15 tasks

[EPIC] Support fastify #932

Romakita opened this issue Sep 20, 2020 · 9 comments

Comments

@Romakita
Copy link
Collaborator

Romakita commented Sep 20, 2020

Informations

The goal is to provide a @tsed/platform-fastify package to support Fastify.

Take as example the @tsed/platform-express and @tsed/platform-koa as examples:
https://github.com/TypedProject/tsed/tree/alpha/packages/platform-express
https://github.com/TypedProject/tsed/tree/alpha/packages/platform-koa

Tasks

Board:
https://github.com/orgs/tsedio/projects/4/views/1

All Fastify related issues:
https://github.com/tsedio/tsed/issues?q=is%3Aopen+is%3Aissue+label%3AFastify

Acceptance criteria

  • Ts.ED server start on Fastify
  • All integration test works
@Romakita Romakita self-assigned this Sep 20, 2020
@Romakita Romakita mentioned this issue Sep 20, 2020
18 tasks
@Romakita Romakita modified the milestones: Hacktoberfest, V6 Oct 3, 2020
@stale
Copy link

stale bot commented Dec 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 2, 2020
@stale stale bot closed this as completed Dec 9, 2020
@Romakita Romakita added pinned and removed wontfix labels Dec 17, 2020
@Romakita Romakita reopened this Dec 17, 2020
@Romakita Romakita pinned this issue Mar 20, 2021
@stale
Copy link

stale bot commented Mar 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 10, 2022
@stale stale bot closed this as completed Mar 18, 2022
@Romakita Romakita reopened this Mar 18, 2022
@stale stale bot removed the wontfix label Mar 18, 2022
@vincent-thomas
Copy link

Fighting with the stale bot? Haha

@Romakita
Copy link
Collaborator Author

Yes ^^. I haven’t started this feature, but it’s a goal ^^

@vincent-thomas
Copy link

It would be awesome if this framework could support fastify! I'm thinking of using this framework instead of nestjs. Leaning against tsed ☺️

@Romakita Romakita moved this to In progress in Global Board Oct 3, 2022
@Romakita Romakita changed the title [v6] Support fastify [v7] Support fastify Oct 10, 2022
@vibh1103
Copy link

Hi @Romakita,
Can i pick this task ?

@Romakita
Copy link
Collaborator Author

Hum, the PR is already started here:
#2437
But no time to continu the dev :)

@vibh1103
Copy link

Thanks for update is there any other task I'll pick ?

@Romakita
Copy link
Collaborator Author

Romakita commented Sep 27, 2023

Hello @vibh1103
You help on this enhancement is welcome!
We can work together on this PR ;). We can split the issue in subtasks like this:

  • Remove all koa reference inside the fastify package (source files and tests files) (PR #)
  • Map Fastify Response to PlatformFastifyResponse (PR #)
  • Map Fastify Request fo PlatformFastifyRequest (PR #)
  • Implement the mapHandler() method in PlatformFastify (PR # )
  • Implement the mapLayers() method in PlatformFastify (PR # )
  • Implement the useRouter() method in PlatformFastify (PR # )
  • Implement the multipart() method in PlatformFastify (PR # )
  • Implement the statics() method in PlatformFastify (PR # )

Note: I added theses tasks on the first message on this story

You can make small PR for each tasks ;). It will me help a lot :). If you have any question. Tell me!

See you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

No branches or pull requests

3 participants