docs: Update PNPM commands #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request updates the documentation across multiple files to modify the project initialization command for Ts.ED using pnpm. The changes replace the previous command Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hi @ThanatosGit See you |
|
Hi, Neither set the value manually nor relying on the default works for me. It maybe is an issue with thanatos@DESKTOP-5NP8L7E:~/projects/tsed-repos/init-test$ pnpm --package=@tsed/cli dlx tsed init .
Downloading @swc/[email protected]: 17.31 MB/17.31 MB, done
WARN 1 deprecated subdependencies found: [email protected]
Packages: +83
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 105, reused 0, downloaded 88, added 83, done
.cache/pnpm/dlx/rnzi4ehbwa6qos5yfkxu3ogi6a/19475254ac0-6911/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@swc/core: Running postinstall script, done in 20ms
Downloading @swc/[email protected]: 21.01 MB/21.01 MB, done
WARN Issues with peer dependencies found
.
└─┬ @tsed/cli 6.1.6
└── ✕ missing peer @tsed/cli-core@"*"
Peer dependencies that should be installed:
@tsed/cli-core@"*"
node:internal/modules/esm/resolve:857
throw new ERR_MODULE_NOT_FOUND(packageName, fileURLToPath(base), null);
^
Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@tsed/cli-core' imported from /home/thanatos/.cache/pnpm/dlx/rnzi4ehbwa6qos5yfkxu3ogi6a/19475254ac0-6911/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@[email protected]_@[email protected]_@tsed+hook_ey6nmjfbea5ksczo7peoxijdgi/node_modules/@tsed/cli/lib/esm/bin/tsed.js
at packageResolve (node:internal/modules/esm/resolve:857:9)
at moduleResolve (node:internal/modules/esm/resolve:926:18)
at defaultResolve (node:internal/modules/esm/resolve:1056:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:654:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:603:25)
at #resolveAndMaybeBlockOnLoaderThread (node:internal/modules/esm/loader:619:38)
at ModuleLoader.resolveSync (node:internal/modules/esm/loader:636:52)
at Object.resolve (node:internal/modules/esm/initialize_import_meta:33:25)
at file:///home/thanatos/.cache/pnpm/dlx/rnzi4ehbwa6qos5yfkxu3ogi6a/19475254ac0-6911/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@[email protected]_@[email protected]_@tsed+hook_ey6nmjfbea5ksczo7peoxijdgi/node_modules/@tsed/cli/lib/esm/bin/tsed.js:11:53
at ModuleJob.run (node:internal/modules/esm/module_job:271:25) {
code: 'ERR_MODULE_NOT_FOUND'
}
Node.js v22.13.0 |
|
Arf... the "peerDependencies": {
"@tsed/cli-core": "workspace:*",
"@tsed/core": ">=8.0.0",
"@tsed/di": ">=8.0.0",
"@tsed/hooks": ">=8.0.0",
"@tsed/logger": ">=7.0.1",
"@tsed/openspec": ">=8.0.0",
"@tsed/schema": ">=8.0.0"
}But it should be the same issue with other peerDependencies listed above. |
|
I merged a PR to try to fix peerDeps for the CLI ^^ |
|
EDIT: Oh, the comment is gone 🙃 |
|
Ok it's fixed now we can use the following command to install cli correctly: pnpm --package=@tsed/cli@latest dlx tsed init .@ThanatosGit can you update your PR please ;) |
|
You need also to update the this file: https://github.com/tsedio/tsed-vitepress-theme/blob/main/packages/theme/organisms/home/terminal/HomeTabTerminalPnpm.vue |
ThanatosGit
force-pushed
the
change-pnpm-cmd
branch
from
bb70ff5 to
a7811df
Compare
|
I left out |
ThanatosGit
force-pushed
the
change-pnpm-cmd
branch
from
a7811df to
8ae92e4
Compare
|
I added latest for pnpm command because pnpm doesn't install the latest version if you already installed the cli using dlx. Npm and yarn always try to install latest. |
|
I wasn't aware of that. I tried to find some documentation about it and tried to reproduce. See console log at the end: That might be because I explicitly requested an older version first and then omitted the version but it was pulling the newer version (because the prompt worked at the second attempt). According to this comment Anyways: Should I include thanatos@DESKTOP-5NP8L7E:~/projects/tsed-repos$ rm -rf /home/thanatos/.cache/pnpm/
thanatos@DESKTOP-5NP8L7E:~/projects/tsed-repos$ echo $(pnpm store path)
/home/thanatos/.local/share/pnpm/store/v3
thanatos@DESKTOP-5NP8L7E:~/projects/tsed-repos$ rm -rf $(pnpm store path)
thanatos@DESKTOP-5NP8L7E:~/projects/tsed-repos$ pnpm --package=@tsed/[email protected] dlx tsed init .
Downloading @swc/[email protected]: 17.31 MB/17.31 MB, done
Downloading @swc/[email protected]: 21.01 MB/21.01 MB, done
WARN 1 deprecated subdependencies found: [email protected]
Packages: +83
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 105, reused 0, downloaded 88, added 83, done
.cache/pnpm/dlx/v2cti3auz46hvfggoeecbbntc4/194761c48a7-6eda/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@swc/core: Running postinstall script, done in 21ms
WARN Issues with peer dependencies found
.
└─┬ @tsed/cli 6.1.4
└── ✕ missing peer @tsed/cli-core@"*"
Peer dependencies that should be installed:
@tsed/cli-core@"*"
node:internal/modules/esm/resolve:857
throw new ERR_MODULE_NOT_FOUND(packageName, fileURLToPath(base), null);
^
Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@tsed/cli-core' imported from /home/thanatos/.cache/pnpm/dlx/v2cti3auz46hvfggoeecbbntc4/194761c48a7-6eda/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@[email protected]_@[email protected]_@tsed+hook_ubsk4icuuhyc7nlzmv3upozjh4/node_modules/@tsed/cli/lib/esm/bin/tsed.js
at packageResolve (node:internal/modules/esm/resolve:857:9)
at moduleResolve (node:internal/modules/esm/resolve:926:18)
at defaultResolve (node:internal/modules/esm/resolve:1056:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:654:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:603:25)
at #resolveAndMaybeBlockOnLoaderThread (node:internal/modules/esm/loader:619:38)
at ModuleLoader.resolveSync (node:internal/modules/esm/loader:636:52)
at Object.resolve (node:internal/modules/esm/initialize_import_meta:33:25)
at file:///home/thanatos/.cache/pnpm/dlx/v2cti3auz46hvfggoeecbbntc4/194761c48a7-6eda/node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]_@[email protected]_@[email protected]_@tsed+hook_ubsk4icuuhyc7nlzmv3upozjh4/node_modules/@tsed/cli/lib/esm/bin/tsed.js:11:53
at ModuleJob.run (node:internal/modules/esm/module_job:271:25) {
code: 'ERR_MODULE_NOT_FOUND'
}
Node.js v22.13.0
thanatos@DESKTOP-5NP8L7E:~/projects/tsed-repos$ pnpm --package=@tsed/cli dlx tsed init .
WARN 1 deprecated subdependencies found: [email protected]
Packages: +359
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 381, reused 87, downloaded 277, added 359, done
.cache/pnpm/dlx/rnzi4ehbwa6qos5yfkxu3ogi6a/194761c7b13-6f91/node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@swc/core: Running postinstall script, done in 21ms
? Choose the target Framework: (Use arrow keys)
❯ Express.js
Koa.js
thanatos@DESKTOP-5NP8L7E:~/projects/tsed-repos$ |
|
we will add |
|
🎉 This PR is included in version 8.4.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
Installation command from https://tsed.dev/introduction/getting-started.html is wrong.
Fix
Instead of using the outdated/deprecated
pnpxusepnpm dlxand also add peer dependencies.E.g.
pnpm --package=@tsed/cli --package=@tsed/cli-core dlx tsed init .Summary by CodeRabbit
pnpmsyntax.pnpx -p @tsed/cli tsed initwithpnpm --package=@tsed/cli dlx tsed init .andpnpx -p @tsed/cli tsed init tsed-prismawithpnpm --package=@tsed/cli dlx tsed init tsed-prisma.