Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add references to possible discussions about upstreaming this #1

Open
voxpelli opened this issue Dec 1, 2020 · 3 comments
Open

Add references to possible discussions about upstreaming this #1

voxpelli opened this issue Dec 1, 2020 · 3 comments

Comments

@voxpelli
Copy link

voxpelli commented Dec 1, 2020

For someone who haven't followed the history of tsd it would be neat to have it documented here why these methods hasn't been exposed upstream – if there's eg. an opposition from the TypeScript team to them or if there's something else blocking it.

I guess long term goal is to not have to maintain a fork like this?

(Also: Sorry for jumping on here with an issue this quickly, I understand it might be premature, not trying to stress you out or anything, just want to be helpful 🙂)

@SamVerschueren
Copy link
Collaborator

Hi @voxpelli! No worries, I would be definitely up for it to have this exposed upstream.

Working on automating the build/release process to have a cronjob run every couple of hours checking if we need to release a new version. This would make it much easier for tsd to follow the TypeScript release cycle. But it's definitely not ideal, because it requires a separate typescript dependency. Although this is actually a drop-in replacement for typescript, people will probably not use it like that.

@skarab42
Copy link

Hello @SamVerschueren @voxpelli

I would also like to see these methods exposed by TypeScript directly and I'm not sure why they aren't. For several reasons, but in particular because I needed a solution that mixed tsd-typescript and byots quickly I developed my own solution unleashed-typescript I do not maintain a TypeScript fork. Instead I use the user installed package, make a copy, patch it and export it back.

@voxpelli
Copy link
Author

voxpelli commented Dec 9, 2023

One of these methods will become official in 3.4: microsoft/TypeScript#56448

And to answer my own question I asked in the start of this issue: This is the thread that discusses exposing these methods in unmodified TS: microsoft/TypeScript#9879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants