split: footprint-dialog.spec.ts into multiple files #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveibar
reviewed
Dec 9, 2024
There was a problem hiding this comment.
can you put all of these into a folder "footprint-dialog" since they're all related to the footprint dialog
also CCing @ShiboSoftwareDev for review (his is more important)
|
@seveibar done. |
|
looks good to me, make sure the tests are passing |
Anshgrover23
force-pushed
the
split-test
branch
from
5d85dea to
b6ff3ff
Compare
ShiboSoftwareDev
approved these changes
Dec 11, 2024
This was referenced Jan 24, 2025
This was referenced Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #364
/claim #364