Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pcb_keepout as obstacles #40

Merged
merged 3 commits into from
Sep 6, 2024
Merged

add pcb_keepout as obstacles #40

merged 3 commits into from
Sep 6, 2024

Conversation

imrishabh18
Copy link
Member

No description provided.

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
autorouting-dataset ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 5:53pm

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, would recommend a quick test for your sanity in case there's a subtle but but looks correct. Most likely a format issue on the last line of your diff

@seveibar
Copy link
Contributor

seveibar commented Sep 6, 2024

@imrishabh18 i think the issue might be that you need to update the @tscircuit/soup dependency to fix the type issue

@imrishabh18
Copy link
Member Author

Will test this and then merge

@imrishabh18 imrishabh18 merged commit 1ad0c72 into main Sep 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants