Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Summary to add 2nd Barz article #336

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Update Summary to add 2nd Barz article #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a9ee90
Update Summary
PowerStream3604 Jun 5, 2024
faa8682
Update text
PowerStream3604 Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions SUMMARY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,4 @@
- [FAQ](wallet-core/faq.md)
- [Barz - Smart Wallet](barz-smart-wallet/barz-smart-wallet.md)
- [Introducing Barz. TrustWallet's Smart Wallet Solution](barz-smart-wallet/introducing-barz-trustwallet-smart-wallet-solution.md)
- [Cutting Diamonds: How to make Accounts Awesome](barz-smart-wallet/cutting-diamonds-how-to-make-accounts-awesome.md)
2 changes: 1 addition & 1 deletion barz-smart-wallet/cutting-diamonds-how-to-make-accounts-awesome.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ if (_action == IDiamondCut.FacetCutAction.Add) {

Although we understood that this was the default behavior of Diamonds which is updating each function selector’s mapping to facet address value, we tried to look for ways tailored to the Account to reduce the gas consumption as much as possible.

During this time, author of [EIP-2535](https://eips.ethereum.org/EIPS/eip-2535) and I had a discussion on how we could further optimize the gas consumption during the `diamondCut()` for default facets, and we came up with an interesting idea of having a pre-existing entity that holds the values for the Diamond’s functionSelector <> Facet mapping.
During this time, [Nick(Author of EIP-2535 Diamonds)](https://x.com/mudgen) and I had a discussion on how we could further optimize the gas consumption during the `diamondCut()` for default facets, and we came up with an interesting idea of having a pre-existing entity that holds the values for the Diamond’s functionSelector <> Facet mapping.

After having this interesting idea, our team started the implementation of a standalone contract that provides the default mapping value of the diamond, and named it `DefaultFallbackHandler`.

Expand Down