Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request Template #5

Open
Elaniobro opened this issue Jun 6, 2019 · 2 comments
Open

Pull Request Template #5

Elaniobro opened this issue Jun 6, 2019 · 2 comments
Labels
❓ question Further information is requested 🆘 help wanted Extra attention is needed

Comments

@Elaniobro
Copy link
Member

Place holder issue for discussing what this template should look like. #1

@CallMeGwei
Copy link
Member

The subsections should have some brief description text, imho - to make expectations even more clear.

For instance: Issue(s) - can be interpreted as ... Are there any new issues? Does this address an existing issue? Did you have issues implementing something?

I propose something like this:


Description: ✍️
What's this pull request all about, in your own words?

Issue(s): 🎟️
Does this pull request address a specific issue that was raised? Reference the issue number.

Visual: 🔍
Screenshots, drawings, ascii art? A picture can be worth a thousand words, etc, etc.

Reference(s): 📖
Did you look things up somewhere? Have a link? Something to cite?

@Elaniobro
Copy link
Member Author

@CallMeGwei sounds gud to me. Do you think the "descriptions" should be html comments or there for the user to keep/delete?

@Elaniobro Elaniobro added ❓ question Further information is requested 🆘 help wanted Extra attention is needed labels Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❓ question Further information is requested 🆘 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants