Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Truffle v5.0.0-beta.0 Release Page Documentation Error #1421

Closed
1 task
jerryji opened this issue Nov 13, 2018 · 1 comment
Closed
1 task

Truffle v5.0.0-beta.0 Release Page Documentation Error #1421

jerryji opened this issue Nov 13, 2018 · 1 comment

Comments

@jerryji
Copy link

jerryji commented Nov 13, 2018


Issue

At the Truffle v5.0.0-beta.0 release page ( https://github.com/trufflesuite/truffle/releases/tag/v5.0.0-beta.0 ), the solc optimizer example incorrectly puts the config under "settings", while they should have been child of "solc" --

// Optimization and EVM version settings
compilers: {
  solc: {
    settings: {
      optimizer: {
        enabled: true, // Default: false
        runs: 1000     // Default: 200
      },
      evmVersion: "homestead"  // Default: "byzantium"
    }
  }
}

Steps to Reproduce

checkout @seesemichaelj 's comment at --

trufflesuite/ganache#960 (comment)

Expected Behavior

solc optimizer enabled

Actual Results

solc optimizer not enabled

Environment

  • Operating System: Ubuntu 18.04
  • Ethereum client: Ganache 1.2.2
  • Truffle version (truffle version): Truffle v5.0.0-beta.1 (core: 5.0.0-beta.1)
  • node version (node --version): v8.12.0
  • npm version (npm --version): 6.4.1
@eggplantzzz
Copy link
Contributor

@jerryji Thanks for the heads up about this! We have updated the release notes. I'm going to close this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants