This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Fix help & readme typo for EIP-170. (2k -> 24k) #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeseese
approved these changes
Sep 24, 2018
There was a problem hiding this comment.
Super fail on my part. That typo is in 2 other repositories 😂
Thanks for catching this! I'll go fix this in the other places (https://github.com/trufflesuite/ganache-core and https://github.com/ethereumjs/ethereumjs-vm)
mikeseese
referenced
this pull request
in trufflesuite/ganache
Sep 24, 2018
Thanks to https://github.com/tenthirtyone for catching this. This fixes a typo that 0x6000 is 24k and not 2k. See #571 for details.
|
Here are the links to the fixes for the other repos: ethereumjs/ethereumjs-monorepo#358 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change, text only.
EIP-170 restricts contract size to <24k not 2k.
I was testing contracts around ~23k in size and having problems with the production gas limit configured so I assumed this was not a functional issue.
Cheers