Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclusion regexes no longer work on 3.65.0 #2350

Closed
JanDemaerelArqGroup opened this issue Jan 29, 2024 · 6 comments
Closed

exclusion regexes no longer work on 3.65.0 #2350

JanDemaerelArqGroup opened this issue Jan 29, 2024 · 6 comments
Labels

Comments

@JanDemaerelArqGroup
Copy link

JanDemaerelArqGroup commented Jan 29, 2024

Please review the Community Note before submitting

TruffleHog Version

3.65.0

Trace Output

N/A

Expected Behavior

trufflehog to honour file regexes in file passed on with -x (--exclude-paths) and uri "." (no quotations)

Actual Behavior

trufflehog 3.64.0 honoured file regex exclusions (e.g. ".git"), but 3.65.0 does not

Steps to Reproduce

  1. create file with a high entropy string in it
  2. create exclusion file, with the prior file-name as content
  3. run trufflehog --no-update filesystem -x <exclusion file> .
  4. trufflehog does not honour exclusions mentioned in exclusion file

Environment

docker ubuntu-latest
trufflehog 3.65.0

Additional Context

N/A

References

N/A

@dustin-decker
Copy link
Contributor

Thank for your prompt report - we will look into this.

@JanDemaerelArqGroup
Copy link
Author

note, my exclusion list contains both directories and files, which are promptly both ignored :)

@AshleyEke
Copy link

Not sure if it's related but this has started happening to me within the last couple of days. I am specifically using the docker image version 3.47.0 though.

@kagahd
Copy link

kagahd commented Jan 30, 2024

I confirm @JanDemaerelArqGroup observation.
Keep in mind to run trufflehog with parameter --no-update else trufflehog will update itself to the latest version and you may wonder why an older trufflehog version (< 3.65.0) still seems to have this newly introduced bug.

@mcastorina
Copy link
Collaborator

Sorry for the regression! It should be fixed in v3.66.2

@AshleyEke
Copy link

@kagahd Thank you I wasn't aware of the --no-update flag and it solved my issue. However, I am a little confused about the purpose of that flag, doesn't it defeat the purpose of installing a specific version of the CLI, or using a specific version of the docker image if it always uses the latest by default anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

5 participants