From f9628f5156d300919d4c475a9b1b376e1bddc08b Mon Sep 17 00:00:00 2001 From: themylogin Date: Thu, 5 Sep 2024 12:00:21 +0200 Subject: [PATCH] Ignore `fast_dedup` feature --- libzfs.pyx | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/libzfs.pyx b/libzfs.pyx index 592f56f..10cfe2e 100644 --- a/libzfs.pyx +++ b/libzfs.pyx @@ -29,6 +29,21 @@ include "config.pxi" include "nvpair.pxi" include "converter.pxi" +IGNORED_FEATURES = {'fast_dedup'} + + +cdef all_features(): + cdef list features = [] + for i in range(0, zfs.SPA_FEATURES): + feat = &zfs.spa_feature_table[i] + + if feat.fi_uname in IGNORED_FEATURES: + continue + + features.append(feat) + + return features + class DatasetType(enum.IntEnum): FILESYSTEM = zfs.ZFS_TYPE_FILESYSTEM @@ -1538,8 +1553,7 @@ cdef class ZFS(object): if enable_all_feat: opts = opts.copy() - for i in range(0, zfs.SPA_FEATURES): - feat = &zfs.spa_feature_table[i] + for feat in all_features(): opts['feature@{}'.format(feat.fi_uname)] = 'enabled' copts = NVList(otherdict=opts) @@ -3149,8 +3163,7 @@ cdef class ZFSPool(object): features_nv = NVList(nvl) - for i in range(0, zfs.SPA_FEATURES): - feat = &zfs.spa_feature_table[i] + for feat in all_features(): f = ZPoolFeature.__new__(ZPoolFeature) f.feature = feat f.pool = self