Wrong links in task output

[DenisBalan]

We are using this task 'trstringer/manual-approval' for manual approval process in enterprise server.

in output can see different urls, mixed formats, either pointing to github.com or to local endpoint, but not clickable because it drives you to api link..

This issue is to address those links formats and make them clickable.

Thx.

[DenisBalan]

In issue description also wrong links, should point to local Github Enterprise Server

[yuqu]

The issue should have been fixed with #125 and #112.

@trstringer we need a release to see the changes on trstringer/manual-approval@v1

@DenisBalan alternatively you may point your action to main branch (trstringer/manual-approval@main) until a release is published.

[martian-str33t]

@trstringer Could we release a new version with the fix?

[matt-horwood-mayden]

@trstringer please progress this

also linked to #128

[venkatamutyala]

@trstringer 🙏🏾

[adHosta]

Yeah I'm also seeing the same issue with the wrong link being provided.
The "api" prefix should be removed from the URL link.

[lzhou-aops]

Would love to see this fix released as well!

[ClaytonHughes]

EDIT: The understanding that was behind my comment is wrong.

Using the latest version of this repository doesn't matter, because the action is going to be pulling whatever the latest published docker image is. So the fix is unavailable without either:

a. forking and hosting your own image.
b. waiting for a new release

---

@yuqu I don't believe those commits fix the issue. If I pin the sha containing those commits, I still get see the api.github.com url in the issue body.

For reference, the (sanitized) workflow step configuration:

# jobs.*.steps:
    - name: Manual Gate
      if: ${{ env.deploy_environment == 'QA' }}
      timeout-minutes: 15
      # pin: two url bugfixes not yet included in a release (as of 1.9.1)
      uses: trstringer/manual-approval@d2e412d84000579996fd00d7834a817f92af19d3 # or 51b76c4576aad25fefe130f04f4cc4de75814e94, same result
      with:
        secret: ${{ steps.team-approval-auth.outputs.token }}
        approvers: qa-approvers
        minimum-approvals: 1
        issue-title: "Deploying to ${{ env.deploy_environment }}"
        issue-body: >
          Please approve or deny the deployment to
          ${{ env.github_environment }}
          from ${{ github.ref_type }} ${{ github.ref_name }}
        exclude-workflow-initiator-as-approver: true
        additional-approved-words: ''
        additional-denied-words: ''

And the created Issue:

Title:

Manual approval required for workflow run 12345678901: Deploying to QA

Body:

Please approve or deny the deployment to QA from branch fix/manual-approval-link

Workflow is pending manual review.
URL: https://api.github.com/ORG/REPO/actions/runs/12345678901

Required approvers: [usera userb userc]

Respond "approved", "approve", "lgtm", "yes" to continue workflow or "denied", "deny", "no" to cancel."

[dan-buzan-mesh]

Hello, do you have an update when the new release will be out?