Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't get the approval values #106

Open
MamadouSadio opened this issue Aug 8, 2023 · 8 comments
Open

Can't get the approval values #106

MamadouSadio opened this issue Aug 8, 2023 · 8 comments

Comments

@MamadouSadio
Copy link

MamadouSadio commented Aug 8, 2023

Please can someone explain me how can i get the approval values (yes, approve...) when i click on the approve and deploy button in the Review pending deployment pop up. I want to make some conditions with it in my following step but it doesn't work and i don't see any example about that in the docs.
I got always a pending status in Manual Workflow Approval step before fail.

@G-Gowtham
Copy link

I am also facing the same issue

@MamadouSadio
Copy link
Author

MamadouSadio commented Aug 18, 2023

It's taking so much time just to get a reply

@MamadouSadio
Copy link
Author

I am also facing the same issue

Hi @G-Gowtham Are you find a eventual solution ?

@trstringer
Copy link
Owner

Sorry, I'm not understanding the problem. You can't find the approval keywords? Those are hardcoded.

@G-Gowtham
Copy link

G-Gowtham commented Oct 19, 2023

@MamadouSadio @trstringer It seems I can't able to approve the request which is created by myself even though I am a assignee.

@Casperjuel
Copy link

@MamadouSadio @trstringer It seems I can't able to approve the request which is created by myself even though I am a assignee.

I'm experiencing the same, can't seem to approve the workflow at all.

@Velink
Copy link

Velink commented Nov 25, 2023

Were you guys able to figure out what the problem is? - The action opens the issue successfully for me - but it won't register when I comment a 'approve' or 'approved' keyword in order to continue the workflow, I've also set 'exclude-workflow-initiator-as-approver:' to false - but no luck.

So I figured out the reason was that I had set myself in the approvers field as 'velink' but it is case-sensitive so updating it to 'Velink' fixed it.

Huge thanks to the @trstringer for creating this - it will save me $100 a month not having to get GitHub Enterprise. The only feature my team required from Enterprise is the manual approval step to deploy to production, and we wouldn't have utilised any of the other features offered by Enterprise just had to pay for them which would have been a waste.

@JoHuang
Copy link

JoHuang commented Apr 19, 2024

Got the issue, too.
The approvers field is case-sensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants